Vitek-Lab / MSstats

R package - MSstats

74 stars 46 forks source link

plotly for design sample #121

Closed deril2605 closed 6 months ago

deril2605 commented 6 months ago

Motivation and Context

Please include relevant motivation and context of the problem along with a short summary of the solution.

Previously Plotly for design Experiment was implemented directly in MSstatsShiny, now the code has been migrated and made more robust to match like ggplot2.

Associated PR on Shiny: https://github.com/Vitek-Lab/MSstatsShiny/pull/89

Changes

Please provide a detailed bullet point list of your changes.

Added Plotly code in designSampleSize.R
A new parameter to the function designSampleSizePlots, isPlotly to toggle between the plotting libraries
Updated documentation for the function

Testing

Please describe any unit tests you added or modified to verify your changes.

Checklist Before Requesting a Review

[x] I have read the MSstats contributing guidelines
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

tonywu1999 commented 6 months ago

Hey Deril, this looks mostly good to go, some minor comments above.

Also, could you add a basic unit test to verify that the function returns a successful response when isPlotly is set to true? A unit test should provide future devs peace of mind that they don't break your changes when they work in the same code base.