Vitek-Lab / MSstats

R package - MSstats
74 stars 46 forks source link

docs(remove50Missing): Clarify documentation regarding remove50Missing parameter #123

Closed tonywu1999 closed 5 months ago

tonywu1999 commented 6 months ago

Motivation and Context

I got questions regarding the remove50Missing parameter, and then realized that the documentation is a bit hard to follow and doesn't define the feature well. Adjusted the parameter definition.

Changes

Testing

Checklist Before Requesting a Review

tonywu1999 commented 6 months ago

Looking into the dry run errors right now. I think they're unrelated to my changes.

Fix: https://github.com/Vitek-Lab/MSstats/pull/124

mstaniak commented 5 months ago

Thank @tonywu1999. @devonjkohler I think we discussed this some time ago. Was the conclusion that it's better to actually remove this parameter? There's a question about it in the google group again, I'll double check the behavior of this and related options [counts].