Vitek-Lab / MSstats

R package - MSstats
74 stars 46 forks source link

[WIP] Annotation validation function #130

Closed mstaniak closed 3 weeks ago

mstaniak commented 3 months ago

Motivation and Context

112, moreover, some tools export annotation in a way that doesn't match expectation of MSstats

[in short, such outputs require concatenation of BioReplicate and Condition to match repeated measures design]

Changes

Please provide a detailed bullet point list of your changes.

Questions:

Testing

None yet, can add unit tests after we decide the functionalities.

Checklist Before Requesting a Review

tonywu1999 commented 3 months ago

I think this is a good start - I'm thinking we should eventually work with users to see what would be ideal in their eyes from a user experience perspective before adding features like reporting a summary table or displaying balanced/imbalanced design info.

I'm also wondering if annotation files should be validated inside the converters, but that would add an additional parameter of "design type" to each converter, which I don't think we want.

As an additional thing - validating that there are at least 2 bioreplicates per condition would be good to have here as well.

mstaniak commented 3 months ago

I think it's OK to just merge user's annotation at the converter step without checking. If there is an error in it, fixing it is just a matter of re-labeling one column

mstaniak commented 3 months ago

TODO: