Vitek-Lab / MSstats

R package - MSstats
74 stars 46 forks source link

fix(groupComparison): Fix .checkTechReplicate function to return true if any tech replicates exist #132

Closed tonywu1999 closed 2 months ago

tonywu1999 commented 2 months ago

Motivation and Context

A user pointed out an issue where the .checkTechReplicate function returns FALSE unexpectedly despite there being technical replicates in an experiment. Looking into it, .checkTechReplicate returns true if all SUBJECT+GROUP combinations have > 1 run, but it should return true if any SUBJECT+GROUP combinations have > 1 run. Otherwise, we end up fitting the wrong model here, e.g. fitting a linear model instead of a linear mixed effects model where the subject is the random effect.

Changes

Testing

Checklist Before Requesting a Review