search

Vitek-Lab / MSstats

R package - MSstats
74 stars 46 forks source link

gloabla standard peptides processing error #59

Closed MASHUOA closed 2 years ago

MASHUOA commented 3 years ago

In .normalizeGlobalStandards please change: standard = input[PEPTIDE == peptide_name, ] into: standard = input[PEPTIDE %in% peptide_name, ] Or: 

for (eachID in  peptide_name){
standard = input[PEPTIDE == peptide_name, ]
}

The dataprocess() only takes the peptide sequence as standard and parses them into a list of peptide_charge which may contains multiple entries like peptide_2 and peptide_3.

mstaniak commented 3 years ago

Hi, thanks for letting us know, I'll check the logic again and correct early this week

mstaniak commented 3 years ago

Hi, I'm considering some other minor updates, so this will need to wait a moment before going to Bioconductor, but you can install version that includes your proposed changes by running

devtools::install_github("Vitek-Lab/MSstats", ref = "hotfix-global-standards")

Please let me know if it fixed the problem for you