Vitens / phreeqpython

Object-oriented python wrapper for the VIPhreeqc module
Apache License 2.0
68 stars 19 forks source link

Added optional unit parameter to kinetics #25

Open uliw opened 1 year ago

uliw commented 1 year ago

It seems that the kinetic method always assumes that the rates returned by the rate_function are in mmol.

codecov[bot] commented 1 year ago

Codecov Report

Merging #25 (08f44ff) into master (d6f94d8) will not change coverage. The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   75.50%   75.50%           
=======================================
  Files           7        7           
  Lines         698      698           
=======================================
  Hits          527      527           
  Misses        171      171           
Impacted Files Coverage Δ
phreeqpython/solution.py 83.87% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.