Filepaths in main files behave differently to filepaths in included files

VitorVilela7 / UberASMTool

This tool lets you insert level, overworld, game mode, status bar, sprite and global ASM without using a patch.

GNU General Public License v3.0

19 stars 13 forks source link

Filepaths in main files behave differently to filepaths in included files #20

Open DiskPoppy opened 3 years ago

DiskPoppy commented 3 years ago

In the files included directly from the list, filepaths (in insrc, incbin, table, %prot_source, etc.) are treated as relative to UberASMTool.exe. However, in the incsrc'd files, the filepaths are treated as relative to the file's location.

VitorVilela7 commented 2 years ago

Sorry for the late question, but do you have any example in what potential problems this can have exactly? If I remember correctly, Asar lets you configure which folders to look for the ASM files, but I don't remember if this misbehavior is intentional or if it's something that is caused by UberASM Tool internals.

DiskPoppy commented 2 years ago

From what I can remember it just caused confusion, but it was solved I think by replacing incbin "../<file>" with incbin "/../<file>", same with incsrc, in the prot_file and prot_source macros in macro_library.asm. However, I'm not sure as as of 1.4 and 1.5 incsrc, incbin, table appear to work as expected now, but I'm not using the prot macros anymore.