VitorVilela7 / UberASMTool

This tool lets you insert level, overworld, game mode, status bar, sprite and global ASM without using a patch.
GNU General Public License v3.0
19 stars 13 forks source link

Purpose of SpriteASM #27

Open MarioFanGamer opened 2 years ago

MarioFanGamer commented 2 years ago

If you think about, what is actually the purpose of having SpriteASM in UberASM? Ever since the patch, it has been around... somewhere and whatever p4's plan was, it was never realised considering I don't know any use of SpriteASM which justifies its behaviour. The procedures to set up SpriteASM is the same as manipulating sprites with Gamemode- and LevelASM except more complicated in the sense that you have to set the pointer to some tables and also lacks safety in the sense that the sprite slot could be occupied by a different sprite. The result is that it is a feature which actually can be depreciated for the next UberASM version. If there are complainers, simply tell them that they should simply handle that in the main code instead. It only eats freeRAM otherwise.

Furthermore, which really tells how unused it is, SpriteASM also is broken in its current state in the sense that the return address for the sprite label is missing a -1 next to the .next:

        PHK
        PEA.w .next
        JMP [!dp]
    .next