Incorrect order total is passed to Viva payments from Magento 2 store with multiple currencies

VivaPayments / API

Index of Viva Wallet open source projects on GitHub.

139 stars 163 forks source link

Incorrect order total is passed to Viva payments from Magento 2 store with multiple currencies #1212

Closed Ddcdom closed 4 years ago

Ddcdom commented 4 years ago

The order total passed to Viva for authorisation from the Magento 2.3 plugin is GrandTotal, not BaseGrandTotal. GrandTotal is the value in the store's display currency, not the store's base currency.

I've created pull request #1211 to fix this issue. Please note these changes are untested.

Ddcdom commented 4 years ago

I've now tested my change and can confirm that they work as expected. Please can you accept my pull request?

VivaWalletSupport commented 4 years ago

Thank you for bringing this up. For your situation this modification might work (to always use the stores default currency). In a preferred setup, using various currencies with various Viva accounts, this mod will be a problem.