VivaPayments / API

Index of Viva Wallet open source projects on GitHub.
139 stars 162 forks source link

Payment Icons are missing from shopify footer #2218

Closed jonsvarn closed 2 years ago

jonsvarn commented 2 years ago

After switching to the new viva payments plugin the payment icons of the selected payment providers are missing from the footer.

can3ry commented 2 years ago

Hello @jonsvarn

We appreciate your message and that you reached out to us directly.

Could you give us some more details about the payment icons? Do you mean the logos of card schemes?

Please also share your merchant id and screenshots related to the payment icons area.

Kind regards, Viva Wallet Development Team

jonsvarn commented 2 years ago

Yes the i mean the logos. I have switched to the new plugin in 4 shops so far. And the chosen payment providers logos on the footers are missing from all of them. With other shop which uses mollie as a payment gateway the logos are appearing as normal. As you can see on the shop using viva wallet the only logo visible is from paypal (which is also active as a payment gateway) Screenshot 2022-07-05 at 1 32 55 PM Screenshot 2022-07-05 at 1 32 15 PM .

can3ry commented 2 years ago

Hi @jonsvarn

Would you mind sharing a full screenshot and a domain name please?

I've checked old and new integrations from Shopify and the logos seem okay.

payment-method-select

Thanks

Kind regards, Viva Wallet Development Team

jonsvarn commented 2 years ago

Hi i dont mean the logos during checkout these work fine as they were before - as i wrote on my first thread the logos that are missing are the ones on the footer. Shopify pulls these logos according to which payment methods are activated on the backend... This is defined on the footer.liquid file {% for type in shop.enabled_payment_types %} and it should show automatically all the enabled payment methods. Screenshot 2022-07-05 at 2 33 43 PM

So an alternative fix when this is not working , is to modify this code and manually (by text) define the icons you want to display on the footer. The code for this is the following {% assign enabled_payment_types = 'visa,master,american_express,paypal' | remove: ' ' | split: ',' %} {% for type in enabled_payment_types %}

So as you can see on the footer since the switch to the new plugin it will only display the paypal icon and none of the the other available payment methods. Screenshot 2022-07-05 at 2 29 02 PM

can3ry commented 2 years ago

Hello @jonsvarn

Thanks for the further details.

If you replace shop.enabled_payment_types with enabled_payment_types in the for loop, it would work. Please see the example below

        <div class="footer__payment">
          <span class="visually-hidden">{{ 'sections.footer.payment' | t }}</span>
          <ul class="list list-payment" role="list">
            {% assign enabled_payment_types = 'visa,master,american_express,discover,diners_club,maestro,paypal,apple_pay,google_pay,ideal,jcb,klarna,sofort' | remove: ' ' | split: ',' %}
            {%- for type in enabled_payment_types -%}
              <li class="list-payment__item">
                {{ type | payment_type_svg_tag: class: 'icon icon--full-color' }}
              </li>
            {%- endfor -%}
          </ul>
        </div> 
payment-methods

In the meantime, I'll make the engineering team aware of this issue.

I presume this will solve your problem. So I am closing this ticket for now. Please do not hesitate to open it again if you have any questions.

Kind Regards Viva Wallet Development Team

jonsvarn commented 2 years ago

Hi, I was wondering if you were able to fix the issue with the payment icons.

I have managed to place the icons manually to 3 shops but unfortunately i cant do this for every shop.

For instance i have a shop with the (paid) theme "Expanse" and (paid) theme "Testament" and the integration which shows automatically the payment icons does not work for viva payments. For other providers like paypal gateway or other providers works fine.

Can you please help me out and let me know how can i get support from viva on this.

Thanks in advance

jonsvarn commented 2 years ago

@can3ry

Hi, I was wondering if you were able to fix the issue with the payment icons.

I have managed to place the icons manually to 3 shops but unfortunately i cant do this for every shop.

For instance i have a shop with the (paid) theme "Expanse" and (paid) theme "Testament" and the integration which shows automatically the payment icons does not work for viva payments. For other providers like paypal gateway or other providers works fine.

Can you please help me out and let me know how can i get support from viva on this.

Thanks in advance

VivaWalletCustomerSupport commented 2 years ago

Hello @jonsvarn,

Thank you for your reply. So far we have not made any changes. Your suggestion is still under review for future implementations.

In any case, stay tuned for updates and changes.

Kind regards, Viva Wallet E-commerce Support Team

jonsvarn commented 2 years ago

@VivaWalletCustomerSupport It's surprising that you closed this issue as "completed" again. This issue is not a suggestion. It has to do with a core function of shopify. Most of the payment providers like mollie or paypal or stripe etc. depending on which payement services you wish to activate (mastercard, visa, amex etc.) display the icons of the activated services automatically on the footer of your shopify store. Once more this request is not a suggestion. This was functioning as usua without the need to edit the footer.liquid code and since the viva plugin changed last june/july it just stopped working. Please fix it or at least help us out with some personalized support (code snippet)so that i can copy paste it to my store and make sure that will work without further customization.

VivaWalletCustomerSupport commented 2 years ago

Hello @jonsvarn,

Sorry for the inconvenience. We can fully understand how important this is for you. Upon further reviewing this case, we have noticed that footers are being displayed after installing our latest Shopify plugin version.

However, when other payment providers are also activated, a conflict arises. So this is not something we update/change from our end. Given this, your best course of action is to contact Shopify support for a work around or a fix.

Just a note, this is the web page footer and not related to checkout page. This footer does not depend on the selected payment methods on viva wallet settings.

I hope this clears the situation. Should you have any other inquiries we are always here for you.

Kind regards, Viva Wallet E-commerce Support Team

jonsvarn commented 2 years ago

Helllo @VivaWalletCustomerSupport Thanks for your reply. So just to clarify this so that i can then submit a ticket at shopify is that for example if i use two different payment gateways paypal and viva then something on shopify end does not work as intented and if i deactivate paypal for instance and use only viva then the icons will be displayed as normal.

Is that correct?

VivaWalletCustomerSupport commented 2 years ago

Thank you for getting back to us.

Keep in mind that apart from plugins/payment providers a theme could cause the conflict. In our test after a fresh installation conflicts do not arise. With that in mind kindly contact Shopify to troubleshoot and if the issue persists we will be here to provide the required assistance in your case.

Kind regards, Viva Wallet E-commerce Support Team

jonsvarn commented 2 years ago

@VivaWalletCustomerSupport Hi i just tested as advised and removed the paypal gateway and i left only viva as an active payment gateway. Unfortunately there are no icons displayed on the footer. I am using Expanse theme (version 3.0.1) and i tested this with two more Shopify themes (Refresh & Dawn) and no payment icons are displayed. (The "display payment icons" option was activated on the themes i tested out) . So dont know what to do next. Contact shopify? Or do you want to take a look at it?

VivaWalletCustomerSupport commented 2 years ago

Hello @jonsvarn,

As a first step try contacting Shopify to confirm or not where the issue is coming from, if this does not fix it we will review it again. Thanks in advance.

Kind regards, Viva Wallet E-commerce Support Team

VivaWalletCustomerSupport commented 2 years ago

@jonsvarn

You can also check the links below as well to confirm what we mentioned for your own convenience.

Kind regards, Viva Wallet E-commerce Support Team

VivaWalletCustomerSupport commented 2 years ago

Hello @jonsvarn,

I just wanted to follow up on the reply I sent yesterday. I was simply wondering if you managed to contact Shopify. Are there any other questions, I may help you with?

In any case this conversation will remain active for at least 24 hours, so that you can come back if you wish.

I hope this information helps, however, should you have any questions, please don't hesitate to reply back here and I'd be happy to help out!

Kind regards, Viva Wallet E-commerce Support Team

jonsvarn commented 2 years ago

Hi @VivaWalletCustomerSupport
Yes i have contacted shopify yesterday and they will investigate the issue and come back to me. Thanks

VivaWalletCustomerSupport commented 2 years ago

Good morning @jonsvarn,

Thank you for letting us know. Kindly keep us posted on any updates.

Kind regards, Viva Wallet E-commerce Support Team

VivaWalletCustomerSupport commented 2 years ago

Hello @jonsvarn,

I hope you are well and you are having a good week. Are there any updates on this? I will leave this communication active for 24 hours more for getting back to us.

Needless to say that should you have any other inquiries we are always here for you.

Kind regards, Viva Wallet E-commerce Support Team

jonsvarn commented 2 years ago

Hi @VivaWalletCustomerSupport Shopify tested the theme i am using along with a shopify theme and they were able to reproduce the same issue. They will connect me with the developer team so that they can check whether they are receiving the necessary data from the gateway through Shopify in order to display the icons. And then i will get back to you. Please leave this open. Thanx

VivaWalletCustomerSupport commented 2 years ago

Hello @jonsvarn,

Thank you for letting us know. Please keep us posted either way.

Kind regards, Viva Wallet E-commerce Support Team

VivaWalletCustomerSupport commented 2 years ago

Hello @jonsvarn,

I hope you're doing well. Are there any updates on this? I will leave this communication active for 24 hours more for getting back to us if need be.

Kind regards, Viva Wallet E-commerce Support Team

jonsvarn commented 2 years ago

Hello

I am still waiting for an official statement from shopify because the developers of one of the themes i am using mentioned the following via an open reply on the ticket i am having with them and Shopify:

“...the payment icons were implemented through an SDK created by Shopify. Shopify has now decided to deprecate this SDK, you can read more on this here: https://shopify.dev/apps/payments/hosted-payment-sdk. This means that any merchant that is not using Shopify Payments will no longer have any payment icons available to display natively in their footer, for example. We did reach out to Shopify internally on this, and they mentioned that "At this time, there is no clear timeline for when an update will be made, but our team will be advocating internally to get this issue resolved.”

So as you can see after waiting for so long we have an indication of what could be possibly the reason causing this.

I have asked shopify to seriously investigate this and requested to provide me with an official statement on this so that i can inform you respectively about this issue.

On 12 Oct 2022, at 10:38 AM, VivaWalletCustomerSupport @.***> wrote:

Hello @jonsvarn https://github.com/jonsvarn,

I hope you're doing well. Are there any updates on this? I will leave this communication active for 24 hours more for getting back to us if need be.

Kind regards, Viva Wallet E-commerce Support Team

— Reply to this email directly, view it on GitHub https://github.com/VivaPayments/API/issues/2218#issuecomment-1275725091, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZ474N2XLRY2G67TERDROL3WCZTITANCNFSM52SLL2EA. You are receiving this because you were mentioned.

VivaWalletCustomerSupport commented 2 years ago

Welcome back @jonsvarn,

Thank you for letting us know. There is no need to forward us their official statement. I will close this case since the issue is not on our end.

Of course, if we can be involved in any way you can let us know by mentioning us.

I hope that the information I provided was useful and clarified the situation. Should you have any other questions, feel free to contact us again, as we are always here for you remaining at your disposal.

Kind regards, Viva Wallet E-commerce Support Team