search

VivaRado / Advent

Advent Pro Var
SIL Open Font License 1.1
8 stars 4 forks source link

Mastering for Google fonts (Round 1) #21

Closed m4rc1e closed 2 years ago

m4rc1e commented 2 years ago

I've just gone through your repo and made the necessary changes in order for us to host this project.

Whilst working on it, I've discovered that the following glyphs are missing:

guillemotleft «
section §
uni2126 Ω
uni2206 ∆

glyphs_missing

Please can you add them and then I will carry on mastering

VivaRado commented 2 years ago

That was just addressed!

Glyphs: OHM, INCREMENT, guillemotleft, section, where added

m4rc1e commented 2 years ago

Eugh. The latest file you pushed trashed this pr and there are still glyph incompatibilities with your latest push!

Screenshot 2022-01-25 at 10 31 31
VivaRado commented 2 years ago

Works on my side.

By using https://github.com/VivaRado/Advent/tree/master/font_source/UFOs/latest/advent_pro

And running the SH to compile, you can see the new variable favors generated.

The renamed VAR/adventpro-def-VF.ttf (definitive) or AdventPro[ital,wdth,wght].ttf as you call it for Mastering, is newly generated from the UFOs provided.

If your PR breaks then I guess you'll have to sync with master again.

On Tue, Jan 25, 2022 at 12:31 PM Marc Foley @.***> wrote:

Eugh. The latest file you pushed trashed this pr and there are still glyph incompatibilities with your latest push!

[image: Screenshot 2022-01-25 at 10 31 31] https://user-images.githubusercontent.com/7525512/150960355-f16e4330-f0f4-4ad8-9a45-c4835d876963.png

— Reply to this email directly, view it on GitHub https://github.com/VivaRado/Advent/pull/21#issuecomment-1021039735, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKAW637DWGWHIXG5PZ5XU7TUXZ3Z3ANCNFSM5MEOK5NA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>