search

ViveSoftware / VIVE-OpenXR

Other
22 stars 4 forks source link

Compiling Version 2.4.0 fails for all build targets except standalone and android #5

Open Marbl70 opened 3 months ago

Marbl70 commented 3 months ago

When importing the latest version 2.4.0 into Unity where the build target is set to WebGL or iOS or anything except standalone and android there are a number of errors in the console, preventing builds.

.. Library\PackageCache\com.htc.upm.vive.openxr@3dd72f5f56\Runtime\CompositionLayer\Scripts\CompositionLayerPassthroughAPI.cs(641,22): error CS0161: 'CompositionLayerPassthroughAPI.SetPassthroughLayerType(int, LayerType, uint)': not all code paths return a value ...

In those functions there is an ifdef missing:

if !(UNITY_STANDALONE || UNITY_ANDROID)

return false;

endif

This prevents us from using this version of the sdk as we are building for multiple targets, please fix asap.

Thanks, Martin

tony-phlin commented 3 months ago

Thanks for the feedback. We'll fix in next release.