search

ViveSoftware / ViveInputUtility-Unity

A toolkit that helps developing/prototyping VR apps.
http://u3d.as/uF7
Other
352 stars 82 forks source link

AndroidManifest path setting is sometimes not saved #173

Closed mhama closed 4 years ago

mhama commented 4 years ago

About

There's a bug that 'Customized AndroidManifest Path' field in Oculus Android VIU Settings is not saved is some circumstances.

Steps to reproduce

  1. Open the repo with Unity Editor (tested with Unity 2019.3.6f1 on Windows 10)
  2. Switch to Android platform
  3. Add Oculus Mobile Package
  4. Restart Unity Editor
  5. Input some text to Customized AndroidManifest Path field of VIUSettings -> Oculus Android
  6. Restart Unity Editor
  7. the text in the Customized AndroidManifest Path field is wrong (the input text has not saved).

Reason

use of unneeded BeginChangeCheck(). https://github.com/ViveSoftware/ViveInputUtility-Unity/blob/develop/Assets/HTC.UnityPlugin/ViveInputUtility/Scripts/Editor/VRPlatformSettings/OculusGoSettings.cs#L582 and https://github.com/ViveSoftware/ViveInputUtility-Unity/blob/develop/Assets/HTC.UnityPlugin/ViveInputUtility/Scripts/Editor/VRPlatformSettings/OculusGoSettings.cs#L596