Viveckh / Veniqa

MEVN Full Stack E-Commerce Solution. Built using MEVN Stack (Node.js, Express.js, Vue.js, MongoDB) with Developer Friendliness and Cloud Integrations in mind. Previously Powered the Veniqa New York Startup. 100% Customizable. For Demos and Documentation, Visit Official Website
https://www.veniqa.com
MIT License
1.13k stars 279 forks source link

Complete Stripe 3D Secure Integration #158

Closed gfyre closed 3 years ago

gfyre commented 3 years ago

What is this doing?

Integrates Stripe 3D secure with the Payment Intents API. This pull request also includes code that handles errors in making/completing payments and notifies the user about the same.

To test it, simply put in your Stripe secret and public key and use one of the 3D secure cards from https://stripe.com/docs/testing

This URL also includes cards which will intentionally fail a payment. Use those to see how the errors are handled.

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

If yes, please describe how it impacts the application:

The PR fulfills these requirements:

Other information:

smaharj1 commented 3 years ago

Also, please let us know if you guys are using Veniqa for your business. We'd be happy to feature you on our official website.

gfyre commented 3 years ago

Hey @smaharj1, the console logs were put there for testing purposes while I was building the platform. However, I'll get rid of the console logs for this PR. As far as "Swaas Order", that is basically what would print on your card statement. You could change that to anything you'd like.

smaharj1 commented 3 years ago

Hey @smaharj1, the console logs were put there for testing purposes while I was building the platform. However, I'll get rid of the console logs for this PR. As far as "Swaas Order", that is basically what would print on your card statement. You could change that to anything you'd like.

Can you remove the Swaas in that case so that it is generic?

gfyre commented 3 years ago

Hey @smaharj1, the console logs were put there for testing purposes while I was building the platform. However, I'll get rid of the console logs for this PR. As far as "Swaas Order", that is basically what would print on your card statement. You could change that to anything you'd like.

Can you remove the Swaas in that case so that it is generic?

Absolutely.

gfyre commented 3 years ago

@smaharj1 @Viveckh Also, are you guys open to changes to the UI? I'd be happy to work on the front-end in my free time.

Viveckh commented 3 years ago

Sorry guys, been a little occupied lately, so couldn't get around to this. I'll go through the code and also do some thorough testing and get back to you @gfyre . Looks pretty good on my initial skimming.

And yes, we would love contributions in any way, including the UI. We've wanted to support some additional design layouts in the list of options for home page "featured sections". And definitely, the admin panel could use some work in responsiveness across devices. Anything particular you got in mind that you wanted to work on?

gfyre commented 3 years ago

How come this hasn't been merged yet? I've tested this and the code works just fine.