search

Vivecraft / VivecraftMod

An experimental port of Vivecraft to Forge/Fabric
Other
169 stars 40 forks source link

add Parchment mappings #189

Open NicBOMB opened 11 months ago

NicBOMB commented 11 months ago

I've been using them on recommendation from @fayer3 a few months ago and can confirm they have been very helpful.

ferriarnus commented 11 months ago

Oh we didn't have parchement set up? Yeah it's good to add it.

fayer3 commented 11 months ago

if we add Parchment we should also go through, and change all arguments to the parchment names, imo

ferriarnus commented 11 months ago

If we have some mojang names like p_037392, then yeah it would be worth to update those. Changing "color" to "pColor" is not worth it imo. That also doesn't need to be part of this PR, but it could be nice to do it here.

NicBOMB commented 11 months ago

if we add Parchment we should also go through, and change all arguments to the parchment names, imo

If we have some mojang names like p_037392, then yeah it would be worth to update those. Changing "color" to "pColor" is not worth it imo. That also doesn't need to be part of this PR, but it could be nice to do it here.

I was going to make those changes in the add parchment mappings commit, but decided against it. Adding it to the build and using it should be separate commits. I can add another commit applying Parchment names to this PR.