search

Vivecraft / VivecraftMod

An experimental port of Vivecraft to Forge/Fabric
Other
169 stars 40 forks source link

reduce gui helper classes into GuiVROptionsBase #192

Closed NicBOMB closed 11 months ago

NicBOMB commented 11 months ago

Classes extending GuiVROptionsBase need to do alot more than should be necessary to create a screen layout. This commit simplifies the gui classes significantly. I understand these guis and the VRSettings class are going to be removed, regardless of this PR. I split this from my other branch on the off-chance this might be accepted as the final improvements to those gui screens before completely migrating to the single ordered list options screen.

fayer3 commented 11 months ago

there also seem to be some unrelated formatting changes in here

ferriarnus commented 11 months ago

Not just the VRSettings, but also the gui classes might get removed. So I don't think this will be merged

NicBOMB commented 11 months ago

Not just the VRSettings, but also the gui classes might get removed. So I don't think this will be merged

I understand these guis and the VRSettings class are going to be removed

:ok_hand: