search

Vivecraft / VivecraftMod

An experimental port of Vivecraft to Forge/Fabric
Other
169 stars 40 forks source link

cleanup logging #193

Open NicBOMB opened 11 months ago

NicBOMB commented 11 months ago

This branch unifies the various methods for logging into a single import from the common Utils. This branch also moves the message helper from CilentDataHolderVR to the client utils. Duplicate checkGLerror functions were unified in the VRPassHelper. Some org.vivecraft.common.utils.Utils.logger. can be shortened to just Utils. when the client Utils for math functions are removed.

ferriarnus commented 11 months ago

2 Classes named utils isn't really good imo. I need to look at why it's even needed for the logger to be split, but in case we need common and client classes, we should call them CommonUtil and ClientUtil or something.

fayer3 commented 11 months ago

the common.utils.Utils class is from me

ferriarnus commented 11 months ago

Doesn't really matter where it came from, but if we are using both in the same file, imports get messy. We might need a split because of access to the Minecraft instance, but then we need to change the names so it's more clear which is safe to call.