search

Vivecraft / VivecraftMod

An experimental port of Vivecraft to Forge/Fabric
Other
169 stars 40 forks source link

Enable in-game keyboard to optionally activate key bindings #199

Closed Techjar closed 10 months ago

Techjar commented 10 months ago

Disabled by default, since I think it could be bad UX if someone accidentally activates bindings they don't intend to. We can always change it if we determine otherwise. If disabled, a message will pop up in chat when you type without a screen open.

I also included a small refactor of VRSettings for code clarity and some additional functionality.

soup587 commented 10 months ago

hell yeah, been waiting a while for this

fayer3 commented 10 months ago

pressKeyHelper should probably be moved to the InputSimulator, don't need to have the exact same code in two classes

fayer3 commented 10 months ago

and could it be changed to a separate press and release, for stuff that wants bindings pressesd for a longer time, like creates pondering

fayer3 commented 10 months ago

is it okay, if I push to your repo, or do you want to do that yourself

fayer3 commented 10 months ago

but it works fine from what I could see, maybe an option to not close the keyboard, when a new screen pops up would be nice, but that can be done later

fayer3 commented 10 months ago

and could it be changed to a separate press and release, for stuff that wants bindings pressesd for a longer time, like creates pondering

easy to to for the physical keyboard, a bit more work for the pointer one

Techjar commented 10 months ago

I can take care of it myself later, it's no problem.

Techjar commented 10 months ago

and could it be changed to a separate press and release, for stuff that wants bindings pressesd for a longer time, like creates pondering

This is difficult to do as there's a lot of cases where the key could become "stuck" in the pressed state.

Techjar commented 10 months ago

Changes are done, though I didn't actually test them.