search

Vivecraft / VivecraftMod

An experimental port of Vivecraft to Forge/Fabric
Other
168 stars 45 forks source link

Option to decrease brightness below 0? #251

Closed kevina closed 7 months ago

kevina commented 7 months ago

Vivecraft for 1.16 had the ability to decrease the brightness (gamma) below 0. That option was lost, I guess when Vivecraft no longer was a modification of OptiFine.

I miss that option, as for me, especially with the original HTC Vive OLED displays everything looked so much better. I also like the fact that in pitch black I really couldn't see. Normally even if the brightness set to 0, you could still see somewhat. For example, box yourself in, give it a second for your eyes to adjust, and you can likely still see the blocks. For the full effect you might need to make sure there is no light bleed from the room.

For now I found a mod that does so (https://modrinth.com/mod/gamma-utils), but it is awkward to use. It would be nice if the option acted as an override and as only active when you are in VR. With the previously mentioned mod, I always need to increase it back up when not in VR, because it is just too dark for my monitor.

fayer3 commented 7 months ago

oh, didn't know that was missing, will look

kevina commented 7 months ago

In 1.16 the normal brightness slider had the ability to go below 0, I think it was to -50 and labeled as "I Can't See", but I could be mistaken at the exact levels it want down to.

fayer3 commented 7 months ago

yeah, didn't know we forgot to port that

kevina commented 7 months ago

Thanks, it it even possible to modify the brightness slider and have it work with sodium? I figured that is why the ability to do so got lost.

fayer3 commented 7 months ago

we just need to modify sodium aswell

kevina commented 7 months ago

Okay. I was thinking a separate option would be better as it can act as an override to only take effect when in VR. But if you can modify the brightness slider that will work also.

fayer3 commented 7 months ago

so the 1.18 version didn't have that, either forgotten, or on purpose, and that is why we don't have it, because we built off of that version

fayer3 commented 7 months ago

closing this, as it's not really needed, since we are a mod now, and people can just install that gamma mod, if they want to lower the brightness.

Techjar commented 7 months ago

Yeah you can replicate the same functionality with this mod: https://modrinth.com/mod/gamma-utils

fayer3 commented 7 months ago

they already linked that mod

Techjar commented 7 months ago

Oh I didn't see lol