Closed longnd closed 1 year ago
I completed the first round of code reviews. I have focused mostly on the backend application as 1) there were more issues on that part than on the front-end, and 2) we aim to keep the code review process short.
I look forward to hearing your feedback on the open issues π
Thankyou for your feedback Long, I will address the issues and update you!
Thank you @Vivek-sudo for all your efforts spent on the code challenge π I have now reviewed your feedback and fixes for the open issues. We now have sufficient information to wrap up this stage of the recruitment process. Our team will contact you shortly by email about the next steps.
Hello Vivek π , thank you for your effort on the code submission. I am Long, engineering lead at Nimble, and I am happy to be the reviewer for our code review session.
During the review process, I would like to know more about your decisions, and thus I will create issues where I think there could be more improvements regarding your performance here.
At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to raise your questions or share your opinions about the implementation (if any) during the process.
If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. Please note that you don't have to close any of my created issues after merging your PRs, I will help verify and close them for you once they pass. π
We expect the code review process to be completed within 2-3 days at most. As a result, ensure you are responsive during this process. If you need additional time, please inform us right away so that we can plan accordingly.
In the end, I really do hope that you find the process enjoyable. Good luck and happy coding.