search

VividCortex / angular-recaptcha

AngularJS directive to add a reCaptcha widget to your form
http://vividcortex.github.io/angular-recaptcha/
MIT License
496 stars 257 forks source link

CommonJS support #159

Closed fredriks closed 7 years ago

DanielaValero commented 7 years ago

Hello,

Is there a plan to have this merged and published any time soon? Would be good to be able to have commonJS support

mtrias commented 7 years ago

Sure!... i'm glad to merge. Can someone please fix the conflicts first?

TheSharpieOne commented 7 years ago

require('angular-recaptcha'); and import 'angular-recaptcha'; currently work just fine. All this PR does is give you the ability to set variables with the module name so you can give it to angular instead of having to use a string.

fredriks commented 7 years ago

Conflicts resolved!

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 94.262% when pulling 4312d0f2a0f7aedf3179b8867d3bad1e590b315e on fredriks:master into a853512427c2931aba0474e82dff5fdcab327072 on VividCortex:master.

mtrias commented 7 years ago

Thanks @fredriks!

DanielaValero commented 7 years ago

Hi! did not see the notifications about the open tasks for this. Otherwise also would have helped. I am glad that you guys got it merged! Thanks!

Lars-Weber commented 7 years ago

Hey @mtrias ,

thanks so much for dealing with this so quickly!

Could you publish the 4.0.4 release on npm?

mtrias commented 7 years ago

Doh... always forget this. We need a script :P

It's done now!

Lars-Weber commented 7 years ago

np! :-)

Thanks so much!