Fix broken angular translate attr for meta tags in template

VividCortex / angular-recaptcha

AngularJS directive to add a reCaptcha widget to your form

http://vividcortex.github.io/angular-recaptcha/

MIT License

496 stars 257 forks source link

Fix broken angular translate attr for meta tags in template #190

Closed mmsqe closed 7 years ago

coveralls commented 7 years ago

Coverage decreased (-26.2%) to 68.033% when pulling ea21ee5ad858ea60708a29243dd714204a3fd17d on mmsqe:master into 073aa4862b2ca465b9914817928974fa9c72cac4 on VividCortex:master.

coveralls commented 7 years ago

Coverage decreased (-26.2%) to 68.033% when pulling 436211a44f933d37607385ff2adf0068d8135744 on mmsqe:master into 073aa4862b2ca465b9914817928974fa9c72cac4 on VividCortex:master.

coveralls commented 7 years ago

Coverage decreased (-0.8%) to 93.443% when pulling 5d616b500742989cad53be512024781b6b7f05dc on mmsqe:master into 073aa4862b2ca465b9914817928974fa9c72cac4 on VividCortex:master.

coveralls commented 7 years ago

Coverage decreased (-0.8%) to 93.443% when pulling 2ed32a4ffffaf4e7cef0b51180d6f41eefc8a282 on mmsqe:master into 073aa4862b2ca465b9914817928974fa9c72cac4 on VividCortex:master.

coveralls commented 7 years ago

Coverage decreased (-0.8%) to 93.443% when pulling 2ed32a4ffffaf4e7cef0b51180d6f41eefc8a282 on mmsqe:master into 073aa4862b2ca465b9914817928974fa9c72cac4 on VividCortex:master.

coveralls commented 7 years ago

Coverage decreased (-0.8%) to 93.443% when pulling 6c8a5ae0d362d38fe828f55b9ac3cac60313e136 on mmsqe:master into 073aa4862b2ca465b9914817928974fa9c72cac4 on VividCortex:master.

knocte commented 7 years ago

@mtrias can you review please?

coveralls commented 7 years ago

Coverage remained the same at 94.488% when pulling fa37ee2e971906f2c1453571466dea51b1ab154f on mmsqe:master into 18f7372e0ccd9a51c9c39a55e7e7a1c4616787e0 on VividCortex:master.

coveralls commented 7 years ago

Coverage remained the same at 94.488% when pulling e9ce18553e102be0c42f8cc2a5775ef7ed42b02c on mmsqe:master into 18f7372e0ccd9a51c9c39a55e7e7a1c4616787e0 on VividCortex:master.

mtrias commented 7 years ago

What am I reviewing here? Where's the issue that this PR is fixing? I tried the original code and worked fine for me.

mmsqe commented 7 years ago

since when we use translate-attr-content from angular for meta content, meta content becomes empty when using jQuery append, while we can avoid this angular digest issue when using native appendChild.

mtrias commented 7 years ago

Gotcha, thanks for clarifying.

Please remove the files under /release. We'll generate the release files as part of the release process.

mtrias commented 7 years ago

@knocte you also are experiencing this bug? If yes, can you confirm this PR fixes it?

coveralls commented 7 years ago

Coverage remained the same at 94.488% when pulling a25f5f2ec126e7ce89beb78829001e180e301e54 on mmsqe:master into 18f7372e0ccd9a51c9c39a55e7e7a1c4616787e0 on VividCortex:master.

mtrias commented 7 years ago

Thanks @mmsqe !