search

VividCortex / angular-recaptcha

AngularJS directive to add a reCaptcha widget to your form
http://vividcortex.github.io/angular-recaptcha/
MIT License
496 stars 257 forks source link

Remove site key length check #221

Closed UltCombo closed 6 years ago

UltCombo commented 6 years ago

Recaptcha may generate site keys with more than 40 characters now, so the length check is outdated and can throw unexpected errors in such cases.

UltCombo commented 6 years ago

I've had a Recaptcha site key with 41 characters and angular-recaptcha was throwing an error due to this length check. The length check seems superfluous so I believe it can be safely removed.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 94.697% when pulling e240563f0da26d3f1dd2eb8544f70e0189ac382d on UltCombo:patch-1 into a187773e5e730cc54d43379be13e79e9d83f7a50 on VividCortex:master.

mtrias commented 6 years ago

Thanks @UltCombo @TheSharpieOne !

@iambrosi do you have some time to take care of releasing this? I don't have my NPM credentials at hand.

iambrosi commented 6 years ago

This has been published as v4.1.3