search

VividCortex / angular-recaptcha

AngularJS directive to add a reCaptcha widget to your form
http://vividcortex.github.io/angular-recaptcha/
MIT License
496 stars 257 forks source link

Tests #49

Closed ericmdantas closed 8 years ago

ericmdantas commented 9 years ago

Added some unit tests, got 94%+ lines covered.

To get 100% and make the tests easier to maintain, I suggest we change a few things here and there. But that's up to you to decide if it'd be good or not.

Also setup the integrations with Travis CI and Coveralls, all you have to do is sign up in both of their sites and sync this repo.

Let me know what you think =]

TheSharpieOne commented 9 years ago

Can you also add a blurb to the README on how to test, seems like common practice.

ericmdantas commented 9 years ago

By the way, now you can only test if you run either: npm t or grunt test; do you think it's a good idea to run the tests everytime someone runs grunt?

iambrosi commented 9 years ago

@ericmdantas Can you please rebase your branch with master to get back in sync with the latest changes? Then, we'll be able to merge it.

TheSharpieOne commented 8 years ago

Any update on this?

ericmdantas commented 8 years ago

I guess this would need a complete rework by me.

If there's still interest I could check if it's better to refactor this PR or close it and reimplement it.

I'll be able to do it only on Sunday, though.

iambrosi commented 8 years ago

Any news on this?

ericmdantas commented 8 years ago

I rebase locally and there's a few things to change.

I think it'd be better if you close this one, so I can open a new PR with updated stuff.