VizGrimoire / VizGrimoireJS-lib

VizGrimoireJS Library
GNU General Public License v3.0
4 stars 7 forks source link

Fixed browsing while selected release in some pages #20

Closed albertinisg closed 9 years ago

acs commented 9 years ago

Alberto, could you change:

if (ds_name === 'releases') target_page = Utils.createLink('forge.html');

with

if (ds_name === 'releases') {target_page = Utils.createLink('forge.html');}

It is a bad practice (we are doing it wrong in some places) to not using brackers. It is easy to have problems in the future when adding more lines to the if and forgetting to add the brackets.

You have it in two places in the code.

Also, I find better to use "else {" than "else{". But we don't have yet a style guide, so we can live with that.