search

VizierDB / vizier-scala

The Vizier kernel-free notebook programming environment
Other
34 stars 11 forks source link

Trash checkmark can be confusing #285

Closed okennedy closed 10 months ago

okennedy commented 10 months ago

To delete a cell, presently one needs to click the trash icon and then the checkmark.

image

However, in addition to the checkmark's intended connotation (confirmation), it also has other connotations ('good', 'keep'). The latter interpretations may be getting further encouraged emphasized by the use of green. This interaction flow needs to be revised.

One idea would be to explicitly communicate the widget's change to a 'commit/abort' state. e.g., with the following states

[trash] <-> [cancel] | [accept]

This would require two changes:

  1. Replace the trash icon with a cancel icon when in commit state
  2. maybe recolor accept. (We really should recolor accept regardless. Green on Blue is really hard to see. e.g., we could make both icons white.

An alternative idea would be to use the trashcan icon itself to signify confirmation:

[trash:white] <-> [cancel:white] | [trash:white]
okennedy commented 10 months ago

Addressed in ac8c830a017a2d391d881ca55f29ee3b6059bb57