VizierDB / vizier-scala

The Vizier kernel-free notebook programming environment
Other
34 stars 11 forks source link

Code review for profiler dataset summary implementation #314

Open lyao4321 opened 8 months ago

lyao4321 commented 8 months ago

Modifications were to the Dataset.scala and created a DatasetSummary class.

DatasetSummary takes in a projectId and the datasetId and uses it to get the artifact. from there I get all the columns and creates the html for the information. The updateSummary command gets and sets that information to root and you access the information through root.

For Dataset, the original menu commands that were there did not allow me to modify or run commands from within the class. My temporary solution was to just make a modified menu from within the class and set that as the menu instead of the menu that was entered in from the parameters. I was unsure about this solution so I wanted to see if there was a better approach to this.