search

Vizioz / FontAwesomeIconPack

Add Font Awesome to your selectable icons in Umbraco 7 & Umbraco 8
MIT License
5 stars 4 forks source link

Update font-awesome.css #12

Closed blissdigital closed 4 years ago

blissdigital commented 4 years ago

Hey Chris,

Hope you're well mate, it's been a while! Just been using your package (great work) and noticed that a small number of FA Icons (the narrower ones) break the alignment of the Umbraco tree. this small CSS tweak restores the alignment, so thought I'd share with this PR. (Possibly something that should be in the Umbraco core, so that it works with any other custom icon fonts)

Cheers, Matt

readingdancer commented 4 years ago

Hi @blissdigital ( Matt )

Thanks for the PR, can you give me an example of an icon I should be looking at and if possible a screen shot? I can't look at this PR now, but I will try and look at it and merge it in tomorrow.

Thanks again, really appreciate it 👍

Chris

blissdigital commented 4 years ago

Hi Chris,

Of course, a screenshot and an example icon would have been much more helpful!

Here’s a before and after using ‘icon-fa-heading’

before after

Cheers, Matt

readingdancer commented 4 years ago

I have just merged in your change and pushed it up to Our.umbraco.com 👍

Thanks again!

blissdigital commented 4 years ago

You're welcome Chris, I've just uninstalled and reinstalled the new version and can confirm it works 👍🏻