search

Vizir / carnival

[no longer maintained] An easy-to-use and extensible Rails Engine to speed up the development of data management interfaces.
MIT License
31 stars 16 forks source link

Feature/some refactories #131

Closed marcosinger closed 9 years ago

marcosinger commented 9 years ago

Hey! :)

I added some tests for query-form and made some changes. The idea is create small PRs in order to make the review easier. What do you guys think about that?

Let me add a short description of what I did:

test(query-form): Add missing tests

refactor(query-form): Remove some unnecessary methods

Using attr_accessor when is possible and simplifying the to_hash method

apantaliao commented 9 years ago

Hello!

Small PRs are perfect for us... Are you using carnval in your project?

marcosinger commented 9 years ago

hey @apantaliao .. now we're using ActiveAdmin, but I'm proposing replace it by something more simple and extensible and I think Carnival is a better option on that way :)

is this PR g2g?

marcosinger commented 9 years ago

cool.. I'll work more in a few days :)