Vizir / react-native-paypal

Native Paypal payment screen for React Native
MIT License
51 stars 15 forks source link

Callback not working #6

Open samcarlosimpres opened 8 years ago

samcarlosimpres commented 8 years ago

Everything is working fine, but I don't receive the callbacks after the payment. How can I solve that?

chagasaway commented 8 years ago

Hey @samcarlosimpres,

Can you provide a sample project that I can simulate the issue?

Thanks

samcarlosimpres commented 8 years ago

Thanks for your answer @chagasaway,

The sample project is here: https://github.com/samcarlosimpres/PayPal-Test

chagasaway commented 8 years ago

Thanks for the sample @samcarlosimpres, I'll take a deeply look later today on this issue.

chagasaway commented 8 years ago

Hey @samcarlosimpres,

I analysed the issue in the sample repository and figured out that a method was not implemented on your MainActivity.java file.

public void onActivityResult(final int requestCode, final int resultCode, final Intent data) {

   super.onActivityResult(requestCode, resultCode, data);

   if (requestCode == PAY_PAL_REQUEST_ID) {
       payPalPackage.handleActivityResult(requestCode, resultCode, data); // <--
   } else {
       otherModulesHandlers(requestCode, resultCode, data);
   }

}

I have made a PR with this missing method as well: https://github.com/samcarlosimpres/PayPal-Test/pull/1/files

If that method fixes the issue, please let me know to close the issue.

Best regards

samcarlosimpres commented 8 years ago

Sorry for the late answer @chagasaway.

I'd test the code with your changes included and it's still not working. There are two scenarios that I've used:

  1. It cannot find the method otherModulesHandlers.
  2. Removing the else statement of the method, the code compiles and works well. But the app crashes after finishing the payment. The error message is below.

http://imgur.com/07RtJqZ

shaikhussian commented 7 years ago

@samcarlosimpres have you fixed this issue? If you fixed give me suggestions that how to resolve it,Thank you