search

Vizonex / Winloop

An Alternative library for uvloop compatability with windows
https://pypi.org/project/winloop
Apache License 2.0
74 stars 7 forks source link

[Request] Creating CI workflow file to build wheels to support different arch and py ver. #1

Closed FinBird closed 1 year ago

FinBird commented 1 year ago

Hello Vizonex, I found this project very useful for me. I request your help to creating a CI workflow file to automate the build process for wheels, including support for win32 and different py ver(py3.9-py3.12?). This would greatly benefit users who are running systems with 32-bit Windows architecture without building it by themselves. Thank you for your work!

Vizonex commented 1 year ago

Glad you asked :) I haven't looked into it yet and I don't know how to implement it. Do you have any ideas or suggestions how we could do that?

Vizonex commented 1 year ago

No doubt I will have to do more research on this when I have the time to. I'll leave this issue opened until you and I are able to solve it.

FinBird commented 1 year ago

No doubt I will have to do more research on this when I have the time to. I'll leave this issue opened until you and I are able to solve it.

Ok,I will keep in touch with the project. Thanks；）

FinBird commented 1 year ago

I Take a try and build the wheel successful;y but fail to find where it locate. https://github.com/FinBird/Winloop/blob/main/.github/workflows/publish.yml Becasue I Can't build it on my machine, so I just take a try online. Where is the .whl located after the following command run? https://github.com/FinBird/Winloop/blob/a8a4186313ec7fcda0056020028f3bc8527a64f7/.github/workflows/publish.yml#L36 See it https://github.com/FinBird/Winloop/actions/runs/5290975301

Vizonex commented 1 year ago

I'm not sure where it is perhaps a video if it exists will help us determine this but I'm very glad to see that you may have ended up figuring it out a lot of this before I could get to it. I did end up finding an article as well if that helps any https://andrewpwheeler.com/2022/05/10/building-wheel-files-in-github-actions/ as well.

If you need even more help I can always add my discord server to either my about me page or this repo if that will help us out better. I also know of some guys that could also help us with this and I actually gave him a shoutout for figuring out how to install everything for this library correctly.

Vizonex commented 1 year ago

image I may have just now found your problem.

Vizonex commented 1 year ago

Another thing that I haven't done yet is link pypi straight to this repo rather than running twine from my system which maybe our next big problem because if I'm not there and another contributor wants to update everything how will they go about it? I'll be sure to also do that as well. As well as ask Godlygeek about how we will approach these next parts (which is who/where I went to in the first place)

Vizonex commented 1 year ago

@FinBird https://stackoverflow.com/questions/70435286/resource-not-accessible-by-integration-on-github-post-repos-owner-repo-ac Have you tried this yet? Something I always try to do is look up the error word for word in a search engine like tor to figure these things out. Let me link my discord server in the repository and maybe we can talk about this further at some point...

FinBird commented 1 year ago

@FinBird https://stackoverflow.com/questions/70435286/resource-not-accessible-by-integration-on-github-post-repos-owner-repo-ac Have you tried this yet? Something I always try to do is look up the error word for word in a search engine like tor to figure these things out. Let me link my discord server in the repository and maybe we can talk about this further at some point...

Thanks for figure it out, I am repairing it now.

Vizonex commented 1 year ago

You're welcome :)

Vizonex commented 1 year ago

https://github.com/FinBird/Winloop/actions/runs/5290975301/jobs/9580068368 if you go here you'll see the issues... It seems that this might fix one of them... https://stackoverflow.com/questions/57361723/error-when-pull-or-push-to-git-enoent-no-such-file-or-directory#58162631 Turns out it will fix both of your problems. when it's done feel free to send me a pull request and I'll merge it.

Vizonex commented 1 year ago

https://stackoverflow.com/questions/65014768/cant-find-my-python-module-after-installing-on-github-actions I found another thing you should look into

Vizonex commented 1 year ago

@FinBird I added my pypi token for winloop now so any releases I do should in fact work... https://youtube.com/watch?v=d1qS3ZWS7WY

Vizonex commented 1 year ago

@FinBird Since I now added my token for Publishing so everything should now work for us on this end and you should be able to now do a Pull Request and I'll update the pypi package with more wheels for 0.0.7 and close this issue down. I expected pypi not to work but now that I've added my token over here it will in fact be sucessful.

FinBird commented 1 year ago

@FinBird Since I now added my token for Publishing so everything should now work for us on this end and you should be able to now do a Pull Request and I'll update the pypi package with more wheels for 0.0.7 and close this issue down. I expected pypi not to work but now that I've added my token over here it will in fact be sucessful.

See https://github.com/Vizonex/Winloop/pull/2

Vizonex commented 1 year ago

Great Job! I'll update it soon with the new wheels.