Vizonex / Winloop

An Alternative library for uvloop compatability with windows
https://pypi.org/project/winloop
Apache License 2.0
89 stars 8 forks source link

Wheels for 32-bit Windows #20

Closed mush42 closed 4 months ago

mush42 commented 5 months ago

Hi,

Is there a way to obtain (or build) wheels for 32-bit Windows?

Any help is appreciated.

Best

Vizonex commented 5 months ago

I have not made 32 bit a priority yet due to the complication it would bring to automating the wheel creation process however. If you can get everything you need to compile and make me a workflow with 32-bit support added then it will happen. I can go as far as compiling you a libuv 32bit .lib file though.

---------- Forwarded message --------- From: Musharraf @.> Date: Mon, Apr 15, 2024 at 8:54 AM Subject: [Vizonex/Winloop] Wheels for 32-bit Windows (Issue #20) To: Vizonex/Winloop @.> CC: Subscribed @.***>

Hi,

Is there a way to obtain (or build) wheels for 32-bit Windows?

Any help is appreciated?

Best

Reply to this email directly, view it on GitHub https://github.com/Vizonex/Winloop/issues/20, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3K7GGRQ3XB2IH7XAQXUPM3Y5PLXRAVCNFSM6AAAAABGHNG7WKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2DGNZVGQZTIMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mush42 commented 5 months ago

If you can provide me with a 32-bit lib, that would be helpful.

Vizonex commented 5 months ago

@mush42 I think I could do better, I have been thinking a lot about it and it actually would not be hard to tweak and then put into the next update

Vizonex commented 5 months ago

@mush42 I am having trouble with compiling a 32bit version for libuv so may need to wait a bit longer until I have the time to do so. I have been rather busy with other stuff going on.

mush42 commented 5 months ago

@Vizonex No problem at all.

Take your time!

Vizonex commented 4 months ago

@mush42 so I was able to come up with a solution but I will have to modify the vendor directory with my changes. So instead of using a precompiled binary such as .lib file I was able to compile all the C files directly which may solve compatibility issues with 32 bit operating systems since all someone would have to do after I have made my changes is to configure the workflow to add support for 32 bit wheels.

Vizonex commented 4 months ago

@mush42 See: https://github.com/Vizonex/Winloop/commit/0a510d32133488699d2d12b779bb6cb868b551fd https://github.com/Vizonex/Winloop/commit/ec7a4ed00ace8a66e5ac2162542f7702d5c38d59

mush42 commented 4 months ago

@Vizonex this works like a charm. Thanks!