search

Vizonex / Winloop

An Alternative library for uvloop compatability with windows
https://pypi.org/project/winloop
Apache License 2.0
89 stars 8 forks source link

Put all (socket)errors in form UV_ERROR. #24

Closed lschoe closed 4 months ago

lschoe commented 4 months ago

Use same names for errors as in uvloop\includes\uv.pxd.

lschoe commented 4 months ago

Hi @Vizonex! The past couple of days I've made (hopefully) nonbreaking changes throughout the code. It would be nice if you can double check this for the latest version, to see if there are also no problems on your side.

So, the goal with all these changes is to avoid any nonessential differences with uvloop (version 0.19). And also a goal is to resolve issue #18 eventually.

For the upcoming changes I want to be a bit more careful, by first creating a PR for you to check. That way we can go step by step.

This first PR is about renaming the errors related to errno.h and socket errors to names of the form UV_, as done in uvloop\includes\uv.pxd. I don't see problems when running this new code, but that doesn't say much as it's hard to cause these errors to happen.

What do you think about this PR?

lschoe commented 4 months ago

PS. Make sure to use a squash merge to keep the commits history clean.