Vizzuality / front-end-scaffold

A scaffold for new projects on Vizzuality
front-end-scaffold-docs.vercel.app
MIT License
3 stars 0 forks source link

components cleanup #137

Closed mbarrenechea closed 1 year ago

mbarrenechea commented 1 year ago

NEXT:

NEXT ISSUES:

Closes https://github.com/Vizzuality/front-end-scaffold/issues/123

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
front-end-scaffold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 1:43pm
Bluesmile82 commented 1 year ago

I'm updating the PR to recover carousel, cookies, loading and search as they don't exist on shadcn

andresgnlez commented 1 year ago

image

(This is in the Search component) Not the first time we face this issue and it is basically because react-aria does not support SSR by default and you need their provider. I tried to install it but everything crashed 😅 , so not sure what approach should we follow here... For this kind of things personally I don't like react-aria ecosystem, but I am not sure we are going to be able to find an alternative to @react-aria/searchfield and @react-stately/searchfield..


image

On a different page, when I type in the search component, looks like we are passing invalid properties to the button element, can you take a look at this, please?

Bluesmile82 commented 1 year ago

image

(This is in the Search component) Not the first time we face this issue and it is basically because react-aria does not support SSR by default and you need their provider. I tried to install it but everything crashed 😅 , so not sure what approach should we follow here... For this kind of things personally I don't like react-aria ecosystem, but I am not sure we are going to be able to find an alternative to @react-aria/searchfield and @react-stately/searchfield..

image

On a different page, when I type in the search component, looks like we are passing invalid properties to the button element, can you take a look at this, please?

I'm using a simple accessible solution now for this component instead react-aria. Please take a look