search

Vizzuality / layer-manager

A library to get a layer depending on provider and layer spec
https://layer-manager-docs.vercel.app
MIT License
18 stars 12 forks source link

Error finally is not a function #56

Closed davidsingal closed 5 years ago

davidsingal commented 5 years ago

TypeError: "Promise.all(...).then(...).finally is not a function"

In happens in Firefox 68.0.1 64-bit. It is happening in all projects based on create-react-app (webpack, babel an react).

For the moment, I'm only got working using the next: https://github.com/Vizzuality/gfw/blob/develop/app/javascript/app/index.js#L11

I open this issue in order to find the best solution to this problem.

sorodrigo commented 5 years ago

Maybe this is useful. If you want CRA to add polyfill https://github.com/facebook/create-react-app/blob/master/packages/react-app-polyfill/README.md

davidsingal commented 5 years ago

I can confirm it works at least for create-react-app applications. Anyway, I don't understand why we need a polyfill when Firefox supports finally since 58 version. https://caniuse.com/#feat=promise-finally

edbrett commented 5 years ago

This is solved now. Thanks for a great time.