search

Vizzuality / openDRI

Open Data for Resilience Initiative
1 stars 1 forks source link

Issue with the highlighting in the about menu #122

Closed vdeparday closed 8 years ago

vdeparday commented 8 years ago

image

Also some of the items linked to the wrong anchors.

Is that all stuff we can fix from the editor directly? Will look at it more.

apercas commented 8 years ago

Hello, I checked the anchors for the about menu and wasn't able to find any error on them, could you please elaborate the issue?

About changing the behaviour from WP, yes, each anchor points to its referenced id, so you'll just have to rename the id field of the box you want to link, please let me know if you want to dig deeper on this. For the bar itself we'll need to edit the page.php of this theme. (Here, https://github.com/Vizzuality/openDRI/blob/master/page.php#L35 precisely.) And submit a PR so we can test it and upload it to the site.

vdeparday commented 8 years ago

It seems like it is working normally now. There is one thing that is weird, on the resources page the section comes to the middle of the page but on the about page, it comes right at the top. Could make it so that it comes to the top but right at the top, a couple pixels down.

On Thu, Apr 28, 2016 at 7:32 AM, Adrián notifications@github.com wrote:

Assigned #122 https://github.com/Vizzuality/openDRI/issues/122 to @vdeparday https://github.com/vdeparday.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/Vizzuality/openDRI/issues/122#event-644178222

apercas commented 8 years ago

Oh! Sorry, my bad! I forgot to add some style fixes I made, deployed :)

vdeparday commented 8 years ago

Thank you for updating it on the resources page, It is looking good. Just one little detail, could we change the about page slightly so that it is the same spacing at the top of the title when scrolling down to it? On the resources page, there is a couple pixel above the title but on the about page, the menu is almost on top of the tittle. Thank you.

On Fri, Apr 29, 2016 at 4:19 AM, Adrián notifications@github.com wrote:

Oh! Sorry, my bad! I forgot to add some style fixes I made, deployed :)

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/Vizzuality/openDRI/issues/122#issuecomment-215656172

apercas commented 8 years ago

True. Re-measured. Deployed.

vdeparday commented 8 years ago

Thank you, it is looking good on the About page. On the resource page, the space at the top is random, sometimes it is in the middle of the page (for publication and newsletters) but it is fine for the others. Could we also Publications before Notes in the menu order? Thank you

On Tue, May 3, 2016 at 10:55 AM, Adrián notifications@github.com wrote:

Assigned #122 https://github.com/Vizzuality/openDRI/issues/122 to @vdeparday https://github.com/vdeparday.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/Vizzuality/openDRI/issues/122#event-648952749

apercas commented 8 years ago

Change applied over your PR, fixed :)

vdeparday commented 8 years ago

Still see the same issue with Newsletter.

On Wed, May 4, 2016 at 4:49 AM, Adrián notifications@github.com wrote:

Change applied over your PR, fixed :)

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/Vizzuality/openDRI/issues/122#issuecomment-216793758

apercas commented 8 years ago

Done.

vdeparday commented 8 years ago

Thanks !