VlaamseKunstcollectie / Imagehub

A IIIF Presentation API compliant aggregator and web service
GNU General Public License v3.0
1 stars 2 forks source link

add dutch localisation to UV 2? #21

Closed Hobbesball closed 5 years ago

Hobbesball commented 5 years ago

Detailed description of the issue. Our metadata is translated, but Universal Viewer itself doesn't have Dutch localisation. We could explore the possibility of adding nl-BE localisation with a PR on the main Universal Viewer github page, following the way that the Swedish translations were added.

Additionally, we could also look into localising the metadata fields within the JSON manifests themselves. currently, the metadata array looks like this:

"metadata": [
        {
            "label": "Title",
            "value": [
                {
                    "@language": "nl",
                    "@value": "Vechtende mannen"
                },
                {
                    "@language": "en",
                    "@value": "Men Fighting"
                }
            ]
        },
...

metadata labels can be localised within the manifests in this way:

"metadata": [
        {
            "label": [
                {
                    "@language": "nl-BE",
                    "@value": "Titel"
                },
                {
                    "@language": "en-GB",
                    "@value": "Title"
                }
            ],
            "value": [
                {
                    "@language": "nl-BE",
                    "@value": "Vechtende mannen"
                },
                {
                    "@language": "en-GB",
                    "@value": "Men Fighting"
                }
            ]
        },
...

I personally am not sure how to tackle this exactly. Do we do both the pull request and in-manifest localisation, or just one of them, or a different solution altogether? @netsensei @nvanderperren , thoughts?

Hobbesball commented 5 years ago

With UV 3 around the corner we won't take the effort to create a dutch localisation for version 2. Dutch localisation has been added to UV 3, and when we make the switch this will be implemented in Arthub. Closing this issue!