search

VlachosGroup / openmkm

Opensource software to model heterogeneous catalytic reactions. Based on Cantera
MIT License
14 stars 10 forks source link

Fill in the necessary information in all underlined sections and words of “BLANK” in the documentation. #37

Closed wittregr closed 4 years ago

wittregr commented 4 years ago

Please fill in the necessary information in all underlined sections and words of “BLANK” in the documentation.

MaxRCohen commented 4 years ago

Hi @mbkumar, can we get an update on this? Once these sections are filled in, it might help us realize other knowledge gaps we need to fill in, so it would be great if we could get this soon. Thank you for the help!

MaxRCohen commented 4 years ago

Hi @mbkumar, checking in again, could we get this addressed? I hope I'm not pestering too much, but we'll need this to understand the results fully.

mbkumar commented 4 years ago

Sure. Will get to this this weekend.

Bharat

On Thu, Jun 18, 2020, 3:35 PM Max Cohen notifications@github.com wrote:

Hi @mbkumar https://github.com/mbkumar, checking in again, could we get this addressed? I hope I'm not pestering too much, but we'll need this to understand the results fully.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/VlachosGroup/openmkm/issues/37#issuecomment-646265607, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA62VECY542NGWMVCOJMH4LRXJUBNANCNFSM4M7MNH4A .

mbkumar commented 4 years ago

@MaxRCohen, The output section is updated with BLANKS replaced with units. Could you please check it out and let me know if you have comments? Otherwise, I'll close the issue.

MaxRCohen commented 4 years ago

Hi @mbkumar , Thank you. I will take a look at it over the next few days and get back to you.

MaxRCohen commented 4 years ago

Hi @mbkumar, I apologize this took me a bit longer to address than expected. I've reviewed all the BLANKs, and they all seem clear. I also went through and reviewed all remaining Github issues on the outputs documentation and added comments for your review. Thank you for addressing all these points and for the hard work in making this software an optimal tool!