search

VlachosGroup / openmkm

Opensource software to model heterogeneous catalytic reactions. Based on Cantera
MIT License
14 stars 10 forks source link

rctr_state mass values #45

Closed MaxRCohen closed 4 years ago

MaxRCohen commented 4 years ago

Hi @mbkumar, we see you added "mass flow rate into the reactor (in kg/s), mass flow rate out of the reactor (kg/s), mass produced from the surface (in kg/s), net rate of change of mass (kg/s) in the reactor" to the output files documentation for the rctr_state output file. However, we do not see these values in our output file. Can you clarify when we should expect to see these values? Are they for an updated version of OpenMKM, or for specific reactors only?

mbkumar commented 4 years ago

I haven't recompiled the code on vaccines yet. I'll do it today.

Bharat

On Fri, Jul 3, 2020, 12:56 PM Max Cohen notifications@github.com wrote:

Hi @mbkumar https://github.com/mbkumar, we see you added "mass flow rate into the reactor (in kg/s), mass flow rate out of the reactor (kg/s), mass produced from the surface (in kg/s), net rate of change of mass (kg/s) in the reactor" to the output files documentation for the rctr_state output file. However, we do not see these values in our output file. Can you clarify when we should expect to see these values? Are they for an updated version of OpenMKM, or for specific reactors only?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/VlachosGroup/openmkm/issues/45, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA62VECLVXCCE4MF2R3OWN3RZYESRANCNFSM4OP6PG6Q .

MaxRCohen commented 4 years ago

Hi @mbkumar, no rush. Sorry if it seemed like it was a time sensitive situation. To clarify, should we expect to see these values for all reactors with the new version of the code? Again, no rush on this, just wanted to confirm for the documentation.

mbkumar commented 4 years ago

Yes. They are in the new version. I tried compiling openmkm today on caviness but some weird errors are popping up. I emailed Jeff and hopefully we will have a working version on Monday.

Bharat

On Sat, Jul 4, 2020, 10:36 AM Max Cohen notifications@github.com wrote:

Hi @mbkumar https://github.com/mbkumar, no rush. Sorry if it seemed like it was a time sensitive situation. To clarify, should we expect to see these values for all reactors with the new version of the code? Again, no rush on this, just wanted to confirm for the documentation.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/VlachosGroup/openmkm/issues/45#issuecomment-653773510, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA62VEF3IIYMUI2IUJBGHTDRZ445VANCNFSM4OP6PG6Q .

mbkumar commented 4 years ago

The new version of openmkm is up and running on caviness.