Vlad777 / mit-stanford

MIT-Stanford MOOC mashup
2 stars 0 forks source link

use connection.php file in dbclass.php #9

Closed Vlad777 closed 11 years ago

Vlad777 commented 11 years ago

Please remove the hard-coded connection settings in dbclass.php and use connection.php instead. This way we can each have our own connection.php file with our own settings, such as the one on Prof. Tseng's machine is different. This won't require to change the file every time the file is deployed in a different environment...

Vlad777 commented 11 years ago

I guess we can simply rename dbclass.php as connection.php. Looks like we can use the code you posted as a library.

reztic commented 11 years ago

Oh thought that was weird. I mean everyone is going to have their own dbclass.php file anyways. Adding an extra connection.php file will just add more files. You can just edit your Dbclass.php file with the setting you want. Just make sure not to commit it.

Also I think its best if we leave it as dbclass.php, that way the file name describes what the php file is doing.

Vlad777 commented 11 years ago

I'm thinking that Prof. Tseng would have a connection.php file already (like he has for the canvas script) and would want to keep and use it. It would be redundant to keep connection configuration in a second file.

reztic commented 11 years ago

Ok, we can ask later that to do. If he wants a seperate configuration file thats fine.