Plugin does not support aws_appmesh_virtual_gateway and aws_appmesh_gateway_route

naishe commented 3 years ago

The plugin does not seem to support aws_appmesh_virtual_gateway and aws_appmesh_gateway_route.

It does not suggest these modules in autocomplete
It shows unsupported block warning on valid blocks

The examples are taken directly from https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/appmesh_virtual_gateway (latest, at the time of posting this issue the version was mentioned 3.26.0) The details are as follows:

Prerequisites

[x] Ensure you have latest version of plugin installed
[x] Search for possible issue duplicates

Installation details

[x] IDE version (Help->About->Copy to Clipboard)

PyCharm 2019.3.5 (Community Edition)
Build #PC-193.7288.30, built on May 7, 2020
Runtime version: 11.0.6+8-b520.66 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.16
GC: ParNew, ConcurrentMarkSweep
Memory: 1981M
Cores: 8
Registry: 
Non-Bundled Plugins: org.intellij.plugins.hcl

[x] intellij-hcl plugin version (Settings->Plugins) Hashicorp Terraform / HCL Language Support, JetBrains, 0.7.10
[x] Terraform version (terraform -v) terraform -v Terraform v0.14.3

Terraform Configuration Files

resource "aws_appmesh_virtual_gateway" "example" {
  name      = "example-virtual-gateway"
  mesh_name = "example-service-mesh"

  spec {
    listener {
      port_mapping {
        port     = 8080
        protocol = "http"
      }
    }
  }

  tags = {
    Environment = "test"
  }
}

Exception

It shows unknown block type for spec, listener, and port_mapping

Unknown block type spec

Expected Behavior

The autocomplete should work The warnings should not be shown

Actual Behavior

The autocomplete does not work Warnings are shown on valid blocks

Steps to Reproduce

Create a configuration using examples given in Terraform documentation for appmesh_virtual_gateway and appmesh_gateway_route

Observe the following:

The auto-completion does not suggest these resources
Valid blocks show warning as specified above

naishe commented 3 years ago

Continuing the thread, there are more places where the plugin does not work as intended. For example, this code exactly taken from the documentation has two issues:

resource "aws_appmesh_virtual_service" "admin_service" {
  mesh_name = aws_appmesh_mesh.mesh.id
  name = local.admin_service_dns
  spec {
    provider {
      virtual_node {
        virtual_node_name = aws_appmesh_virtual_node.admin_node.name
      }
    }
  }
}

provider block does not come in autocomplete (nor any of the attributes within this tag)
It wrongly shows it as error, as illustrated in the image below

naishe commented 3 years ago

@VladRassokhin sorry to bother, any idea?

haidaraM commented 3 years ago

For different providers resources, check this: https://github.com/VladRassokhin/intellij-hcl#terraform-external-metadata You need to build the schema manually.

naishe commented 3 years ago

For different providers resources, check this: https://github.com/VladRassokhin/intellij-hcl#terraform-external-metadata You need to build the schema manually.

Should it not work out of the box? This is not external meta data. This resource and properties are documented here so, like any other AWS resource the properties should auto complete and not show a warning without requiring the end user to do extra steps.

This project being closed sourced, I can't even pry open and see why is this the case.

haidaraM commented 3 years ago

The providers schemas is embeded with the plugin as the time the plugin is released. Since there is no new release of the plugin, if you want to have autocompletion for the new resources, you will need to do get the schemas manually or maybe use Terraform language server : https://github.com/hashicorp/terraform-ls/blob/main/docs/USAGE.md#intellij-ide

Otherwise, check my fork of the metadata that I update from time to time: https://github.com/haidaraM/terraform-metadata/tree/feat/updateProviders. You have the aws_appmesh_virtual_gateway there :-) Just follow the instructions and should work

VladRassokhin commented 3 years ago

Partially fixed in 0.7.11 Fix for aws_appmesh_virtual_service.spec.provider.virtual_node will be in next update (0.7.13)

VladRassokhin commented 3 years ago

Fixed in 0.7.13

VladRassokhin / intellij-hcl