Vladimir-csp / xdg-terminal-exec

Proposal for XDG Default Terminal Execution Specification and shell-based reference implementation.
GNU General Public License v3.0
77 stars 12 forks source link

cache mock-up #43

Open fluvf opened 10 months ago

fluvf commented 10 months ago

Accidentally based on #42 One monolithic commit as this is a mock-up Notable changes needed to make this work:

I don't know if I like sourceing the cache file, might change that to read loop when cleaning up, if you're happy with the implementation

fluvf commented 10 months ago

Thoughts? Would you be happy with this implementation? I'd have time to clean this up today if you are

Vladimir-csp commented 10 months ago

Thank you. I will dig deeper in it a bit later. What I can see right away is that entry read is still needed.

With current cache implementation, exec line is read directly from the cache.

fluvf commented 10 months ago

Yes, this isn't trying to be faster than the current implementation. Some quick tests prove that it's not. But it is less code to maintain, and the cache should be much harder to invalidate