Vladimir-csp / xdg-terminal-exec

Proposal for XDG Default Terminal Execution Specification and shell-based reference implementation.
GNU General Public License v3.0
73 stars 11 forks source link

xdg-terminal-exec: Misc changes #46

Open fluvf opened 9 months ago

fluvf commented 9 months ago

See commit messages for details These should again be the last changes I had queued up

~~Last two commits, b7f76820bbf9f0443545ac6eb2bda28e1a9a99e8 and dfc44b10685d94c709738cee7de33dcd5a78cc76, are more opinionated I'd like to see them merged, but feel free to cherry-pick them out if you so choose :+1:~~

Vladimir-csp commented 9 months ago

I like everything except removing config validation errors.

fluvf commented 9 months ago

After sleeping on it, I think I agree with you, let me fix that real quick

fluvf commented 9 months ago

I think that rebase worked, can't see any obvious issues with it Nevertheless, please test the terminal list file parsing well Here's what I used to test it:

# a.desktop
b.desktop:action
b!a.desktop
!.desktop
a!.desktop
!a.desktop
.desktop
a.desktop:action!
a.desktop
a.desktop:
a.desktop       :::     action
a    : action