search

Vladimir-csp / xdg-terminal-exec

Proposal for XDG Default Terminal Execution Specification and shell-based reference implementation.
GNU General Public License v3.0
77 stars 12 forks source link

Fix scripts errors #8

Closed notpeelz closed 1 year ago

notpeelz commented 1 year ago

As I was trying out the script, I noticed a couple situations in which the script could fail:

  1. not having any terminals configured and not having xterm installed would result in exec: xterm: not found
  2. an empty data directory would cause all sorts of script errors
  3. a terminal name with an asterisk could get shell expanded (unlikely, but good practice to handle it anyway)
Vladimir-csp commented 1 year ago

using "$EXEC" would treat the whole string including any potential arguments as a name of an executable.

notpeelz commented 1 year ago

Oh I didn't realize they could contain arguments. I'll remove that commit.

Vladimir-csp commented 1 year ago

2382e587aca4a188ff3e47c9b22bfb381ff3adab should solve this. Thank you.