#22 map macro for _IF_BOUND, add docker image to readme - Githubissues

VladimirAlexiev / rdf2rml

RDF by Example: rdfpuml for True RDF Diagrams, rdf2rml for R2RML Generation

44 stars 5 forks source link

#22 map macro for _IF_BOUND, add docker image to readme #23

Closed SCVFlare closed 1 year ago

SCVFlare commented 1 year ago

Used the simplest map macro I could find to handle variable arguments. Added Ontotext's docker image of rdf2rml to README

VladimirAlexiev commented 1 year ago

hi @SCVFlare! I fixed #22 in https://github.com/VladimirAlexiev/rdf2rml/commit/b2d9bc18acc819b39064152382760c2405876134, see the issue for explanation.

I like the implementation with 5 numbered macros better, because it's easier to understand, and for the reasons given in https://stackoverflow.com/a/65997567/20282178.

Do you like this explanation? https://github.com/VladimirAlexiev/rdf2rml/blob/master/doc/rdf2sparql.pod#conditional-nodes

I also added the info about Docker: https://github.com/VladimirAlexiev/rdf2rml#docker-image So I'll close this PR without merging. But will make separate issue about dockerization.