search

VladimirMarkelov / clui

Command Line User Interface (Console UI inspired by TurboVision)
MIT License
670 stars 50 forks source link

Scrollable frame #102

Closed dorileo closed 6 years ago

dorileo commented 6 years ago

This PR includes a small fix, a theme change and a new feature for OnKeyDown events callback calls and more importantly a new feature for frame control. We can now make it scrollable.

@VladimirMarkelov can you please help me in depth reviewing the "frame: scrollable frame" patch? this patch touches very sensible areas and I faced many corner cases while implementing it, I suppose you may find a few more. Can you also test with you current test cases for frame?

Thanks...

VladimirMarkelov commented 6 years ago

A very good one. Thank you! It is long, so it takes some time for me to read and understand. Please be patient ;)

VladimirMarkelov commented 6 years ago

I tried the patch - applications work fine. So, I'll wait for your changes ad we can merge it ;)

VladimirMarkelov commented 6 years ago

And it would be great to have a small example of how to use scrolling frames.

dorileo commented 6 years ago

@VladimirMarkelov updated the set with the requested changes + a patch introducing a small demo with a scrollable frame.