search

Vladinator / wow-addon-compactvendor

Other
2 stars 0 forks source link

Missing goods on the vendor page + lag on opening #12

Open Voxxel opened 1 year ago

Voxxel commented 1 year ago

Hi, Vlad,

This is just a reminder about the most common addon problem of missing goods when we open the vendor page at the first time. You already replied to the issue here:

https://www.curseforge.com/wow/addons/compact-vendor?comment=31

 I have an idea how to avoid this, I do need to rewrite the way I filter the merchant options by filtering them in the frame of the addon itself, and not touch any internal functionality. Currently the internals are altered to filter, but it's not really required, and more a legacy leftover strategy that can be fully avoided. That will also not break or interact with other addons in this manner, so it's the ideal solution and I will be working on in during DF as I also dislike the current approach if I'm honest.

I'm not sure if this is related to this issue but opening a vendor page who has high amount of goods for sale also freezes the game for few seconds, like a massive lag spike.

I pray you could find the time for this in the near future.

Vladinator commented 1 year ago

Both Seltherex and Rethelshi have a similar situation, a lot of items that are equippable, and there was an issue with the appearance collected detection. I changed it with newer code, but it's still not ideal, but worth a test to see if it's in the right direction. It felt like so on my end when I tested a bit before I pushed a new release just an hour ago.

Feel free to try it out if it helps opening the vendor on your end as well.

In general I want to look a bit more into how to load items and avoid any freezes when the vendor opens.

Voxxel commented 1 year ago

I tried it and I see the freezes take a little bit shorter. I found out a lot of other mandatory addons are also contributing in this vendor page opening freeze case such as Bagnon.

I can imagine if an option to filter out unwanted vendor goods may help to eliminate the freeze time even further by simply ignoring the goods from building the vendor stock list on opening. This way a lot of goods could be skipped onload which is unused by the character, such as bop gear for different armor classes, bop recipes for unowned professions, etc.