Vlek / RuinsAndRiches

Ruins & Riches Ultima Online Server Files
6 stars 0 forks source link

Fix error message when not able to equip instruments #25

Closed Vlek closed 1 year ago

Vlek commented 1 year ago

The current garbled message is pretty bad and I am not even sure what it means by 'natural'. Do I need to have some sort of special distinction, or just a certain skill level?

image

Vlek commented 1 year ago

I think what this means without checking the code for the conditional that it's failing on to say literally is: You need to at least be a natural neophyte in musicianship to equip that!

Meaning, without any buffers, the PC must have at least a certain threshold of skill in order to equip the item. I believe that this should be more in line with the minimum skill check exception messages for things like weapon abilities.

Vlek commented 1 year ago

I grep'd for the wording and found a bunch of places in Spellbook.cs with similar bad wording. Will fix those as well in branch.