Change buy options for vendors to increase their chance of buying items

[Vlek]

Nothing is more annoying than having to check whether vendors that would normally buy a given item type will accept the exact item you're trying to sell them at a given point.

I believe that they should have a 100% chance of buying items that are their type. I have a job, I can't be logging in every day to see whether they're going to buy the ingots or whatever I mined a week ago.

[Vlek]

I created a fix for this, but I want to double-check that I got this right because I may have changed whether the NPC sells everything at 100% chance or if they will buy items from the PC at 100% chance.

[Vlek]

I think I did this, but I am worried that the vendors are not buying every item of the type that you would expect them to purchase?

The problem is that I would have some items be able to be sold, and right now I am able to sell what feels like more than I used to, but I am not able to sell all items that could be made via blacksmithy right now.

There are also the items that have pretty powerful magical properties, but I do not know what store to even sell them at? Like trinkets for instance. Some have really decent stats. No idea where to sell them.

I am feeling like any vendor would be interested, especially at the rates that they're willing to provide, in any magical item that the user is wishing to offload.

So I am thinking that, in the interest of balance, maybe have it so that there is a chance at the NPCs accepting items that the user makes, but accepting all magical items, even the ones that they do not normally purchase?

I did however find out that one can place a box in one's house that allows one to make items of a given skill and the items will be "picked up" and gold will be placed in the box to compensate the user for the items. This would give gold for those items with 100% chance, so I am thinking maybe it's better to just leave it at 100%?

The problem is that games usually try not to monetarily incentivize skill gain. The whole point is that you're spending time and resources to gain skill, not gain skill and also profit monetarily. OR, if you are going to do both, it usually comes at the cost of additional time (See Old School Runescape's wiki for details on skill gain methods and their drawbacks).

[Vlek]

Because of the above, I am going to reopen this ticket. Going to require additional work and thinking through.

[Vlek]

Tailors are currently not buying:

• Bone arms
• Bone legs
• Bone helms
• Tricorn hat
• Leather cap

Rangers are not buying:

• Bow
• Short bow

Blacksmiths are not buying:

• Great axe
• Trident
• War fork
• Harpoon
• Halberd
• Royal boots

Alchemists are not buying:

• Greater poison potion
• Conflagration potion

Carpenters:

• Ash Wooden Tunic

[Vlek]

I had to also update the settings.xml file to update the chances. When I did that, then items that at least are currently on these vendors' lists are being bought.

I still need to add items that are not on these people's lists.