search

Vlek / RuinsAndRiches

Ruins & Riches Ultima Online Server Files
7 stars 0 forks source link

Leaving areas show messages stating so twice #7

Open Vlek opened 1 year ago

Vlek commented 1 year ago

Whatever callback is being done when you leave an area is being called twice. This is likely an issue and will cause there to be duplicate effects.

I also changed my starting stats/skills in one area and then left and it reset my skills back down to 0? No idea what that is all about.

Vlek commented 1 year ago

Seems to not happen at the bank, but happens when you leave the basement?

image

Looks like it's because you're leaving the basement AND the basement trapdoor?

image

Vlek commented 1 year ago

Looks like there's a problem with magic strings in the region code.

There's also a serialization happening where the programmer is concatenating stuff into a string instead of saving the variables correctly?

I think it's because PublicRegion.cs already performs a LoggingFunctions.LogRegions for 'the Basement' on enter and exit and BasementDoor.cs has its own code which is also calling it on enter and exit.